fix highlight.js dependency: ^9.15.6 #977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciccarello
reviewed
Feb 25, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "typedoc", | |||
| "description": "Create api documentations for typescript projects.", | |||
| "version": "0.14.2", | |||
| "version": "0.14.3", | |||
There was a problem hiding this comment.
Please don't change the package version number in PRs. This will be done during the release. Thanks!
There was a problem hiding this comment.
sorry, didn’t know that. want me to make another commit or leave it as it is?
There was a problem hiding this comment.
No problem, it's something that's not aways clear for contributors. I'll probably make updates to all the dependencies now that a fix has been pushed so don't worry about updating.
|
highlight.js v9.15.6 fixes security vulnerabilities introduced in v9.15.5. so 3c61b7f bumps the dependency to v9.15.6. |
chharvey
changed the title
|
That's true. Updating should help with #978 |
Merged
aciccarello
added a commit
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should temporarily fix #976 , until
highlight.jsv9.15+ no longer fails on installation (see highlightjs/highlight.js#1984 )see https://www.npmjs.com/package/highlight.js/v/9.14.2 for latest working version