Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccmp code change and vertical metrics #4

Closed
josescaglione opened this issue Jun 20, 2023 · 11 comments
Closed

ccmp code change and vertical metrics #4

josescaglione opened this issue Jun 20, 2023 · 11 comments
Assignees

Comments

@josescaglione
Copy link
Collaborator

As a result of the discussion regarding the vertical metrics we had with @vv-monsalve I tightened the double accents in Pinyin and Viet glyphs. Additionally I replaced our default y by y.ss01 in the ydotbelow glyph, which saves lots of vertical space as it was the deepest character in the font.

In order for the randomizer to work correctly the ccmp entry for ydotbelow must be changed from
sub ydotbelow by y dotbelowcomb;
to:
sub ydotbelow by y.ss01 dotbelowcomb;

@vv-monsalve
Copy link
Collaborator

The new VM at 1.68 UPM looks better but is still a bit loose. Testing it with the Icons included we think it could be reduced to the ~1.5 and have enough room for vertical needs like Vietnamese marks.

Current - Proposed VM comparison
VM-diff-15-16

Proposed values:
Screen Shot 2023-06-22 at 21 01 10

@casasin
Copy link
Collaborator

casasin commented Jun 23, 2023

@vv-monsalve Updated vertical metrics to your proposed values

@davelab6
Copy link
Collaborator

@vv-monsalve please close when verified

@vv-monsalve
Copy link
Collaborator

I'll leave this issue open while we are reviewing VMs for the big Playpen.

@vv-monsalve
Copy link
Collaborator

After a final revision with @josescaglione to the vertical metrics the new agreed values should be:

Screen Shot 2023-08-22 at 11 08 40

Comparative image between current and new values:

diffbrowsers_text-macOS-12 6 3-x86_64-i386-64bit_chrome_116 0 5845 96

@vv-monsalve
Copy link
Collaborator

Font pulled at commit 2ddc98e has the agreed VM values.

@vv-monsalve
Copy link
Collaborator

@casasin after pulling the latest files at commit 750ba63, the font no longer has the agreed VM values, and we have now a new Fail reported.
Screen Shot 2023-09-06 at 14 40 46

@casasin
Copy link
Collaborator

casasin commented Sep 7, 2023

@casasin after pulling the latest files at commit 750ba63, the font no longer has the agreed VM values, and we have now a new Fail reported (…).

@vv-monsalve Somehow rolled back in some source update. They are fixed in latest commit. I hope that's all 🤞🏽

@vv-monsalve
Copy link
Collaborator

@casasin They are working now, thanks.
Could you please turn the repository public? This is needed to create the PR to GF.

@casasin
Copy link
Collaborator

casasin commented Sep 7, 2023

@vv-monsalve : the repo is now public.

@vv-monsalve
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants