Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Next.js demo (with server side rendering) #185

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

mathio
Copy link
Collaborator

@mathio mathio commented Feb 25, 2021

No description provided.

@mathio mathio requested a review from a team February 25, 2021 14:29
const container = useRef();

useEffect(() => {
createWidget("<form id>", { container: container.current });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw somewhere that container was renamed to element. Was it? Not sure though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR was not merged. It is container.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then we're cool.

@codeclimate
Copy link

codeclimate bot commented Feb 25, 2021

Code Climate has analyzed commit 823826f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7%.

View more on Code Climate.

@mathio mathio merged commit b26d6d6 into next Feb 25, 2021
@mathio mathio deleted the demo-nextjs branch February 25, 2021 16:06
@jenkins-tf
Copy link
Collaborator

🎉 This PR is included in version @typeform/embed-v1.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jenkins-tf
Copy link
Collaborator

🎉 This PR is included in version @typeform/embed-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants