Switched from SemaphoreSlim lock to AsyncNonKeyedLocker (#1184)

Tyrrrz · Apr 21, 2024 · 74f99b4 · 74f99b4
1 parent 12b590d
commit 74f99b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/DiscordChatExporter.Core/DiscordChatExporter.Core.csproj b/DiscordChatExporter.Core/DiscordChatExporter.Core.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <ItemGroup>
-    <PackageReference Include="AsyncKeyedLock" Version="6.2.4" />
+    <PackageReference Include="AsyncKeyedLock" Version="6.3.4" />
     <PackageReference Include="CSharpier.MsBuild" Version="0.26.7" PrivateAssets="all" />
     <PackageReference Include="Gress" Version="2.1.1" />
     <PackageReference Include="JsonExtensions" Version="1.2.0" />
@@ -12,4 +12,4 @@
     <PackageReference Include="YoutubeExplode" Version="6.3.10" />
   </ItemGroup>
 
-</Project>
+</Project>
diff --git a/DiscordChatExporter.Gui/ViewModels/Framework/DialogManager.cs b/DiscordChatExporter.Gui/ViewModels/Framework/DialogManager.cs
@@ -1,7 +1,7 @@
 using System;
 using System.IO;
-using System.Threading;
 using System.Threading.Tasks;
+using AsyncKeyedLock;
 using MaterialDesignThemes.Wpf;
 using Microsoft.Win32;
 using Stylet;
@@ -10,7 +10,7 @@ namespace DiscordChatExporter.Gui.ViewModels.Framework;
 
 public class DialogManager(IViewManager viewManager) : IDisposable
 {
-    private readonly SemaphoreSlim _dialogLock = new(1, 1);
+    private readonly AsyncNonKeyedLocker _dialogLock = new();
 
     public async ValueTask<T?> ShowDialogAsync<T>(DialogScreen<T> dialogScreen)
     {
@@ -34,16 +34,11 @@ void OnScreenClosed(object? closeSender, EventArgs closeArgs)
             dialogScreen.Closed += OnScreenClosed;
         }
 
-        await _dialogLock.WaitAsync();
-        try
+        using (await _dialogLock.LockAsync())
         {
             await DialogHost.Show(view, OnDialogOpened);
             return dialogScreen.DialogResult;
         }
-        finally
-        {
-            _dialogLock.Release();
-        }
     }
 
     public string? PromptSaveFilePath(string filter = "All files|*.*", string defaultFilePath = "")