Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field name consistency with the official API #454

Closed
Sanqui opened this issue Dec 14, 2020 · 1 comment
Closed

Field name consistency with the official API #454

Sanqui opened this issue Dec 14, 2020 · 1 comment

Comments

@Sanqui
Copy link
Contributor

Sanqui commented Dec 14, 2020

The JSON export currently uses fields with different capitalization rules and sometimes even wording differences compared to the official API. For instance, timestampEdited and isPinned, which are subtly different from the official edited_timestamp and pinned. I feel like this is unnecessary and confusing for everybody who has to work with it. While it would be a breaking change for the project, I would seriously consider introducing consistency with official fields where possible.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Dec 14, 2020

This is on purpose actually. There is no attempt to keep the field names in sync because DCE's domain representation is vastly different from the Discord's API in several places.

@Tyrrrz Tyrrrz closed this as completed Dec 29, 2020
@Tyrrrz Tyrrrz changed the title [JSON] Field name consistency with the official API Field name consistency with the official API Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants