Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the date format option with a locale option #1130

Merged
merged 14 commits into from
Sep 7, 2023
Merged

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Sep 6, 2023

Closes #879

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1130 (b9103d2) into master (ccdf082) will increase coverage by 0.09%.
The diff coverage is 85.45%.

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   69.01%   69.11%   +0.09%     
==========================================
  Files         107      106       -1     
  Lines        3896     3905       +9     
  Branches      627      631       +4     
==========================================
+ Hits         2689     2699      +10     
+ Misses        979      977       -2     
- Partials      228      229       +1     
Files Changed Coverage Δ
...xporter.Core/Exporting/PlainTextMarkdownVisitor.cs 62.50% <0.00%> (+2.97%) ⬆️
...hatExporter.Core/Exporting/PreambleTemplate.cshtml 85.85% <0.00%> (ø)
...xporter.Core/Exporting/MessageGroupTemplate.cshtml 65.27% <57.14%> (-0.31%) ⬇️
...atExporter.Core/Markdown/Parsing/MarkdownParser.cs 93.38% <66.66%> (-0.61%) ⬇️
...rdChatExporter.Core/Exporting/JsonMessageWriter.cs 75.25% <92.30%> (+0.17%) ⬆️
...hatExporter.Cli/Commands/Base/ExportCommandBase.cs 77.45% <100.00%> (+0.39%) ⬆️
...dChatExporter.Core/Discord/Data/Common/ImageCdn.cs 53.84% <100.00%> (+6.02%) ⬆️
...iscordChatExporter.Core/Exporting/ExportContext.cs 88.52% <100.00%> (+3.90%) ⬆️
...iscordChatExporter.Core/Exporting/ExportRequest.cs 55.04% <100.00%> (+2.16%) ⬆️
...ChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs 83.92% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tyrrrz Tyrrrz merged commit 59344ce into master Sep 7, 2023
15 checks passed
@Tyrrrz Tyrrrz deleted the remove-date-format branch September 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove date format option
1 participant