Fix docker user permissions issues #1194
Conversation
Silex
force-pushed
the
master
branch
11 times, most recently
from
611ff44
to
32aca43
Compare
|
Ok @Tyrrrz I think you can merge. I decided to keep the uid:gid of 1000:1000 for convenience but make it explicit in the Dockerfile, chown the files so it just works the first time the data folder is created, and provide documentation for those who have different ids. Please run some tests yourself. |
DiscordChatExporter.Cli.dockerfile
Outdated
| # https://github.com/Tyrrrz/DiscordChatExporter/issues/851 | ||
| RUN adduser --disabled-password --no-create-home dce | ||
| USER dce | ||
| # Use a non-root user |
There was a problem hiding this comment.
Can you please add a comment explaining why 1000 was chosen specifically as the ID?
There was a problem hiding this comment.
You chose 1000 when you did RUN adduser --disabled-password --no-create-home dce (it's usually the first user id available). And luckily it happens to map with most installations.
I'm just keeping your chosen id and making it explicit.
|
Any updates on this? I am getting the same issue when using docker compose within my workflow |
Tyrrrz
changed the title
Hello,
Don't merge this yet, it's not ready.
Closes #1174