Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Playlist won't download if there is an unavailable video in it. #493

Closed
deadlycfx opened this issue Nov 12, 2021 · 7 comments · Fixed by #657
Closed

[BUG] Playlist won't download if there is an unavailable video in it. #493

deadlycfx opened this issue Nov 12, 2021 · 7 comments · Fixed by #657
Labels
is: bug Something isn't working SCRAPING AUDIO/VIDEO Thing related to some DLs not downloading properly or at all. NOT for subscription-specific issues!
Projects

Comments

@deadlycfx
Copy link

Describe the bug
Playlist won't download if there is an unavailable video in it. It doesn't skip the unavailable video and won't download anything.

To Reproduce
Just download a playlist with and unavailable video.

Expected behavior
Skip the unavailable video and download the rest of the videos.

Environment

  • YoutubeDL-Material 4.2
  • Docker tag: nightly
@deadlycfx deadlycfx added the is: bug Something isn't working label Nov 12, 2021
@GlassedSilver
Copy link
Collaborator

Which fork of yt-dl are you using in your setup? And can you possibly provide logs?

Sorry that I can't get back to you with more than the usual initial trouble-shooting keypoints here and that I reply this late. :/

@mattkbach
Copy link

mattkbach commented Jan 14, 2022

Having the same issue trying to download a playlist with a video in the playlist that is unavailable. Using the latest nightly build (4.2). Tried both youtube-dl and youtube-dlp

https://www.youtube.com/playlist?list=PLZWD78nR1R0nxp-rSjsdtK2J1HErSmOQA

This is what the logs say:

2022-01-14T23:26:16.579Z DEBUG: Removing all records from: files with filter: {"sub_id":"9d016eaf-69dc-4bab-8e6f-57cdb67f8c06"}
2022-01-14T23:26:16.587Z DEBUG: Successfully removed records from files
2022-01-14T23:26:26.367Z VERBOSE: Subscription: getting videos for subscription ACI4 with args: --dump-json,-o,subscriptions/playlists/ACI4/%(uploader)s [%(uploader_id)s]/%(title)s [%(id)s].%(ext)s,-ciw,--write-info-json,--print-json,-f,bestvideo[ext=mp4]+bestaudio[ext=m4a]/mp4,--write-thumbnail,--no-clean-infojson
2022-01-14T23:27:22.179Z VERBOSE: Subscription: finished check for ACI4
2022-01-14T23:27:22.186Z ERROR: WARNING: [youtube:tab] YouTube said: INFO - 2 unavailable videos are hidden
WARNING: [youtube:tab] YouTube said: INFO - Unavailable videos will be hidden during playback
ERROR: [youtube] 2cDoT3gm2Zo: Private video. Sign in if you've been granted access to this video
ERROR: [youtube] 0SfyFOVnjg4: Private video. Sign in if you've been granted access to this video

@GlassedSilver GlassedSilver pinned this issue Mar 25, 2022
@GlassedSilver
Copy link
Collaborator

Pinning this issue now for visibility. I don't really have an idea how to fix this atm and googling this for feedback in regard to yt-dlp and how you'd possibly handle the error there directly with args... I come up empty.

So if anyone smarter than me knows something I'd appreciate pointers or even better a PR. :)

Thank you for reporting the bug you two!

@GlassedSilver
Copy link
Collaborator

yt-dlp's README says that you can use this flag to not abort on errors:

--no-abort-on-error              Continue with next video on download
                                 errors; e.g. to skip unavailable videos in
                                 a playlist (default)

This might help, but it could be that YT-DLM may abort this on its own, not sure. Can you check with yt-dlp and passing this?

@GlassedSilver GlassedSilver added the 💬 response-needed Further information is requested label May 2, 2022
@GlassedSilver GlassedSilver added SCRAPING AUDIO/VIDEO Thing related to some DLs not downloading properly or at all. NOT for subscription-specific issues! and removed 💬 response-needed Further information is requested labels May 26, 2022
@GlassedSilver GlassedSilver added this to Needs triage in 🐞 Bugs * via automation May 26, 2022
@GlassedSilver GlassedSilver added this to the Backlog milestone May 26, 2022
Repository owner deleted a comment from github-actions bot May 26, 2022
@GlassedSilver
Copy link
Collaborator

I think I hastily applied the response-needed label here and had it auto-close when I in fact believe we should at least consider including the --no-abort-on-error arg to the defaults for one-off downloads. Thoughts, @Tzahi12345?

@GlassedSilver GlassedSilver reopened this May 26, 2022
@GlassedSilver GlassedSilver removed this from the Backlog milestone May 26, 2022
@GlassedSilver GlassedSilver added meta: consider Things to consider implementing and removed meta: consider Things to consider implementing labels May 26, 2022
@mikepaxton
Copy link

Curious if any resolution has been achieved to this issue?
As an example below is a playlist I'd like to download but it has three hidden videos which seems to be preventing me from doing so with the same error message as Sleepymatto posted above. I've tried adding the custom arg --no--abort-on-error to the subscription but still to no avail.
https://www.youtube.com/playlist?list=PLRNgjwKiAAEBGH5pHqCai-c5Atu_A4hOT

Tzahi12345 added a commit that referenced this issue Jun 24, 2022
…yt-dlp would cause the entire sub check to fail (#493)
@Tzahi12345
Copy link
Owner

Hi @mikepaxton @deadlycfx, this appears to be a yt-dlp issue. Btw --no-abort-on-error is yt-dlp specific and on by default, but in all youtube-dl forks there's the --ignore-errors are (or -i for short) which we already use.

My guess is that in yt-dlp, --dump-json and --ignore-errors cannot be used in conjunction, that is: errors will be thrown anyways. The good news is that the necessary info to continue the download exists, just in a slightly different place (in err.stdout for those interested).

I updated #657 to include the following commit: d225e84

Should be fixed shortly when that PR closes. Thanks @mikepaxton @sleepymatto @deadlycfx for the report & info!!

🐞 Bugs * automation moved this from Needs triage to Closed Jun 24, 2022
@Tzahi12345 Tzahi12345 unpinned this issue Jun 24, 2022
@GlassedSilver GlassedSilver linked a pull request Jun 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug Something isn't working SCRAPING AUDIO/VIDEO Thing related to some DLs not downloading properly or at all. NOT for subscription-specific issues!
Projects
Development

Successfully merging a pull request may close this issue.

5 participants