4.3 Prep #657

Tzahi12345 · 2022-06-20T20:15:47Z

Summary:

Updated UI for creating/modifying playlists (see demo below)
Playlists are now file type agnostic (that is, you can now mix and match audio files and video files into a playlist)
Subscription file cards now use the new ones on the home page
Fixed Twitch chat downloads
- They are much faster now! Downside is a python dependency is now required (Twitch-Chat-Downloader) as the new Twitch API does not support downloading chat
- A client secret must now be supplied in addition to the client ID
Fixed issue where subscription downloads could not set quality other than max (fixes Error when selecting another "Max quality" #600)
Changed default downloader from youtube-dl to yt-dlp (fixes [RELIABILITY/UX] Make yt-dlp the default for new installations #575)
Version updated to v4.3
Updated translations
Updated API/models
Various code cleanup
Fixed issue where playlist order could not be rearranged
Removed recommendations to use nightly
pm2 moved from global install to local (closes [FEATURE] Using npm start #662)

Demo:
https://user-images.githubusercontent.com/707413/174672249-00990e94-2886-4748-b49a-e2f3761d80c1.mp4

Done testing! Once this is merged, v4.3 will be released!

GetAllFiles can now filter by sub_id Improved API models and added request body docs for GetAllFiles

Playlists are now file type agnostic Updated translations

Fixed issue where playlist order could not be rearranged

backend/subscriptions.js

    ]);

    if (jsonExists) {
-        retrievedID = JSON.parse(await fs.readFile(jsonPath, 'utf8'))['id'];
+        retrievedID = fs.readJSONSync(jsonPath)['id'];


GlassedSilver · 2022-06-20T22:49:30Z

Maybe removing the recommendations to use the nightly branch would be a good idea.

Same for docker-compose.yml.

…st be supplied

backend/twitch.js

…dated SECURITY.md

Temp twitch chat files now get auto removed

backend/twitch.js

…ocess, reducing calls to video host

Fixed several dependency vulnerabilities

martadinata666 · 2022-06-24T03:43:53Z

Add to wiki solution for RPI4 or other devices that mongodb throw exception (132).
#614 (comment)

The mongodb log

ytdlt-db-1  | 
ytdlt-db-1  | WARNING: MongoDB 5.0+ requires ARMv8.2-A or higher, and your current system does not appear to implement any of the common features for that!
ytdlt-db-1  |   see https://jira.mongodb.org/browse/SERVER-55178
ytdlt-db-1  |   see also https://en.wikichip.org/wiki/arm/armv8#ARMv8_Extensions_and_Processor_Features
ytdlt-db-1  |   see also https://github.com/docker-library/mongo/issues/485#issuecomment-970864306
ytdlt-db-1  | 
ytdlt-db-1 exited with code 132

and add some references

Tzahi12345 · 2022-06-24T03:54:40Z

Add to wiki solution for RPI4 or other devices that mongodb throw exception (132).

I'm honestly down to just target mongo:4.4.6

Not sure if there's a reason to be at v5 anyways... @GlassedSilver thoughts?

martadinata666 · 2022-06-24T04:00:05Z

Add to wiki solution for RPI4 or other devices that mongodb throw exception (132).

I'm honestly down to just target mongo:4.4.6

Not sure if there's a reason to be at v5 anyways... @GlassedSilver thoughts?

Yeah, updating compose to target mongo:4.4 also will do, it just we also need to add reason why because as you know some folks just why not :latest?

Tzahi12345 · 2022-06-24T04:04:05Z

Yeah, updating compose to target mongo:4.4 also will do, it just we also need to add reason why because as you know some folks just why not :latest?

I did just try on a test instance downgrading and it was not pretty. I'll probably go with your first suggestion and add something to the README for rpi 4

EDIT:

Alright, wiki page is up! https://github.com/Tzahi12345/YoutubeDL-Material/wiki/Raspberry-Pi-4

And README is updated: c6b7e7b

…rial into 4.3-prep

…redownload fresh uploads was enabled (#480)

…yt-dlp would cause the entire sub check to fail (#493)

GlassedSilver

small change I would like to ask for from what I was able to spot so far, other than that LGTM :)

src/app/components/unified-file-card/unified-file-card.component.html

GlassedSilver

LGTM :)

Tzahi12345 added 9 commits June 18, 2022 19:36

Updated version to 4.3

895c385

Added test for ID3 tagging

aca86e0

Updated translation source file

0dd617b

Subscription file cards are now replaced with unified file cards

b5ee0d3

GetAllFiles can now filter by sub_id Improved API models and added request body docs for GetAllFiles

Updated playlist file selection to use recent videos component

690cc38

Playlists are now file type agnostic Updated translations

Updated modify playlist size

7f47fb3

Fixed issue where playlist order could not be rearranged

Unified create and modify playlist components

e1cb56e

Removed modify playlsit component

0951e44

Code cleanup

4c6c15d

github-advanced-security bot found potential problems Jun 20, 2022

View reviewed changes

backend/subscriptions.js

]);

if (jsonExists) {

retrievedID = JSON.parse(await fs.readFile(jsonPath, 'utf8'))['id'];

retrievedID = fs.readJSONSync(jsonPath)['id'];

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on [a user-provided value](1).

Improved snackbar translations support

cbdd1a6

GlassedSilver added this to the v4.3 milestone Jun 20, 2022

Tzahi12345 added 2 commits June 21, 2022 01:22

Fixed twitch chat downloads, tcd is now required and client secret mu…

7bfb297

…st be supplied

Fixed loading spinner in create playlist dialog

901e87a

github-advanced-security bot found potential problems Jun 21, 2022

View reviewed changes

backend/twitch.js Fixed Show resolved Hide resolved

backend/twitch.js Fixed Show fixed Hide fixed

Tzahi12345 added 3 commits June 21, 2022 01:40

Updated dockerfile to include tcd installation

da8c23d

Removed recommendation of nightly, updated language in README, and up…

9d1624d

…dated SECURITY.md

Fixed issue where pip was missing in Docker

cddd280

Temp twitch chat files now get auto removed

github-advanced-security bot found potential problems Jun 21, 2022

View reviewed changes

backend/twitch.js Fixed Show fixed Hide fixed

backend/twitch.js Fixed Show fixed Hide fixed

Tzahi12345 added 4 commits June 21, 2022 01:58

Fixed potential command injection vulnerability

b6de6d0

Updated pip target

6fe0cd5

Utilize yt-dlp filesize approximations if available

39abc3e

Changed default downloader to yt-dlp

636f7b1

martadinata666 mentioned this pull request Jun 23, 2022

[FEATURE] Using npm start #662

Closed

Tzahi12345 added 2 commits June 23, 2022 18:37

Subscription videos now skip the collect info step during download pr…

a0c36bf

…ocess, reducing calls to video host

Removed nodemon

0ffd702

Fixed several dependency vulnerabilities

Tzahi12345 mentioned this pull request Jun 24, 2022

ERROR: connect ECONNREFUSED 127.0.0.1:27017 #614

Closed

Added rpi 4 as a "special case" in the readme

c6b7e7b

Tzahi12345 mentioned this pull request Jun 24, 2022

[FEATURE] Allow metadata for video files to be manually edited #573

Closed

Tzahi12345 added 4 commits June 24, 2022 13:02

Merge branch 'master' of https://github.com/Tzahi12345/YoutubeDL-Mate…

d300a8a

…rial into 4.3-prep

Removed pm2 global install in favor of local node_modules (#662)

fecefde

Completed deprecation of streamingOnly mode for subscriptions

573cca0

Fixed error where sub with no videos would crash if none existed and …

a4a0045

…redownload fresh uploads was enabled (#480)

This was referenced Jun 24, 2022

[BUG] Existing files recognized but still queued #480

Closed

MongoDB Writing Many Subscriptions at Once – Performance Issue #534

Open

Tzahi12345 added 2 commits June 24, 2022 19:26

Fixed issue where errored single videos in playlist/sub downloads in …

d225e84

…yt-dlp would cause the entire sub check to fail (#493)

Minor code cleanup

19a3ffc

Tzahi12345 mentioned this pull request Jun 24, 2022

[BUG] Playlist won't download if there is an unavailable video in it. #493

Closed

UI & logs now use proper fork name rather than just youtube-dl

86cbfea

This was linked to issues Jun 26, 2022

ERROR: connect ECONNREFUSED 127.0.0.1:27017 #614

Closed

[BUG] Playlist won't download if there is an unavailable video in it. #493

Closed

GlassedSilver requested changes Jun 26, 2022

View reviewed changes

Update unified-file-card.component.html

9a250b5

GlassedSilver reviewed Jun 27, 2022

View reviewed changes

src/app/components/unified-file-card/unified-file-card.component.html Show resolved Hide resolved

src/app/components/unified-file-card/unified-file-card.component.html Show resolved Hide resolved

GlassedSilver previously approved these changes Jun 27, 2022

View reviewed changes

Updated source translation file

742129b

Tzahi12345 dismissed GlassedSilver’s stale review via 742129b June 27, 2022 00:59

GlassedSilver approved these changes Jun 27, 2022

View reviewed changes

Tzahi12345 merged commit 68c2ee2 into master Jun 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.3 Prep #657

4.3 Prep #657

Tzahi12345 commented Jun 20, 2022 •

edited

GlassedSilver commented Jun 20, 2022

martadinata666 commented Jun 24, 2022 •

edited

Tzahi12345 commented Jun 24, 2022

martadinata666 commented Jun 24, 2022

Tzahi12345 commented Jun 24, 2022 •

edited

GlassedSilver left a comment

GlassedSilver left a comment

4.3 Prep #657

4.3 Prep #657

Conversation

Tzahi12345 commented Jun 20, 2022 • edited

Done testing! Once this is merged, v4.3 will be released!

GlassedSilver commented Jun 20, 2022

martadinata666 commented Jun 24, 2022 • edited

Tzahi12345 commented Jun 24, 2022

martadinata666 commented Jun 24, 2022

Tzahi12345 commented Jun 24, 2022 • edited

GlassedSilver left a comment

Choose a reason for hiding this comment

GlassedSilver left a comment

Choose a reason for hiding this comment

Tzahi12345 commented Jun 20, 2022 •

edited

martadinata666 commented Jun 24, 2022 •

edited

Tzahi12345 commented Jun 24, 2022 •

edited