Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DS-015 with UDRAL #125

Merged
merged 19 commits into from Oct 15, 2021
Merged

Replace DS-015 with UDRAL #125

merged 19 commits into from Oct 15, 2021

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko commented Sep 18, 2021

Find the context and submit high-level feedback at https://forum.uavcan.org/t/first-draft-of-the-udral-dsdl-namespace/1438

This changeset is expected to be merged by Oct 15 unless there are major breaking proposals.

@auturgy
Copy link

auturgy commented Sep 19, 2021

Thanks @flytrex-vadim for your efforts in proposing a solution to type safety, with port-ID tables and type signatures. @pavel-kirienko beyond that (which is just a note in the readme) I don't see how this PR - which is essentially find/replace drone/udral - addresses the remaining issues detailed here: https://forum.uavcan.org/t/meeting-minutes-july-21-2021-utc-udral-call/1365 and https://forum.uavcan.org/t/problems-with-ds-015/1219/47

@pavel-kirienko
Copy link
Member Author

@auturgy you will find a detailed review of the resolved and outstanding issues in the forum thread I linked in the OP post. Feel free to comment on them in that thread.

@coderkalyan
Copy link
Contributor

This changeset is expected to be merged by Oct 1st unless there are major breaking proposals.

I would suggest allocating more time for interested parties to actually take a look at it in depth and comment - since there were concerns with the original DS-015 message set.

@auturgy
Copy link

auturgy commented Sep 19, 2021

@pavel-kirienko as you well know, that post identifies and addresses issues as you choose, not as or how they've been raised by the stakeholders.
Frankly your approach to this problem raises serious concern regarding leadership and trust. In simple terms, if you don't listen to the Consortium, there won't be a Consortium.
I've raised a consortium vote in an attempt to persuade you to have these discussions publicly.

@pavel-kirienko
Copy link
Member Author

@auturgy if you happen to have any constructive criticism, it would be most welcome on the forum.

@auturgy
Copy link

auturgy commented Sep 19, 2021

My forum feedback:

The issues raised here: https://forum.uavcan.org/t/meeting-minutes-july-21-2021-utc-udral-call/1365
and https://forum.uavcan.org/t/uavcan-drone-application-layer-sig-guidelines/1280/16 provide a good summary of the requirements a UDRAL proposal should meet. The definitions in the PR are nothing but find/replace drone/udral on the DS-015 definitions. With no attempt to address the shortfalls identified in that message set, I see no reason to expect different feedback on them.
As I’ve mentioned before, I think we need to get the design agreed and the tooling in place before publishing message definitions. I don’t think we’re at that point yet.
I’d also suggest that as definitions are developed we leave them in a branch until they’re iterated, agreed, and stable. MAVLink has demonstrated many times that WIP messages have a habit of making their way into production systems, making it very difficult to iterate and change them. That’s why in MAVLink we’ve moved away from WIP messages in favour of development.xml (which is annoying, but a necessary compromise given the workflows in that project).

@pavel-kirienko
Copy link
Member Author

James, I do value your feedback, but let us please keep the conversation on the forum.

@davidbuzz
Copy link

I get "Oops! That page doesn’t exist or is private." On the forum links, can't review.

enegy should be spelled energy
@pavel-kirienko pavel-kirienko merged commit 1565632 into master Oct 15, 2021
@pavel-kirienko pavel-kirienko deleted the udral branch October 15, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants