New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DS-015 with UDRAL #125
Conversation
Context: https://forum.uavcan.org/t/problems-with-ds-015/1219/44?u=pavel.kirienko The physics namespace has been migrated to https://github.com/Zubax/zubax_dsdl/tree/master/zubax/physics If you are using any types from reg.drone.physics, please update your references to zubax.physics.
Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
Thanks @flytrex-vadim for your efforts in proposing a solution to type safety, with port-ID tables and type signatures. @pavel-kirienko beyond that (which is just a note in the readme) I don't see how this PR - which is essentially find/replace drone/udral - addresses the remaining issues detailed here: https://forum.uavcan.org/t/meeting-minutes-july-21-2021-utc-udral-call/1365 and https://forum.uavcan.org/t/problems-with-ds-015/1219/47 |
@auturgy you will find a detailed review of the resolved and outstanding issues in the forum thread I linked in the OP post. Feel free to comment on them in that thread. |
I would suggest allocating more time for interested parties to actually take a look at it in depth and comment - since there were concerns with the original DS-015 message set. |
@pavel-kirienko as you well know, that post identifies and addresses issues as you choose, not as or how they've been raised by the stakeholders. |
@auturgy if you happen to have any constructive criticism, it would be most welcome on the forum. |
My forum feedback: The issues raised here: https://forum.uavcan.org/t/meeting-minutes-july-21-2021-utc-udral-call/1365 |
James, I do value your feedback, but let us please keep the conversation on the forum. |
I get "Oops! That page doesn’t exist or is private." On the forum links, can't review. |
enegy should be spelled energy
Find the context and submit high-level feedback at https://forum.uavcan.org/t/first-draft-of-the-udral-dsdl-namespace/1438
This changeset is expected to be merged by Oct 15 unless there are major breaking proposals.