Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE CHANGE] Logo on home page is not clearly visible #135

Closed
1 of 3 tasks
Ishita-Ghosh-25 opened this issue May 26, 2023 · 7 comments · Fixed by #269
Closed
1 of 3 tasks

[STYLE CHANGE] Logo on home page is not clearly visible #135

Ishita-Ghosh-25 opened this issue May 26, 2023 · 7 comments · Fixed by #269

Comments

@Ishita-Ghosh-25
Copy link
Contributor

Description:

Once we register, the home page logo is partially visible and it does not match the first page logo

Reason for Change:

To improve the user experience

Current Styling:

The logo is not visible due to low contrast

Proposed Styling:

The logo has to be the same as the first page

Screenshots or Design Mockups (optional):
This is how the logo is looking on the home page
image

While in the first page, the logo is clearly visible
image

Additional Information (optional):

[Provide any additional information that may help in understanding or implementing the style change. This can include any specific requirements or constraints.]

Priority Level (optional):

  • Low
  • Medium
  • High

Timeline (optional):

[Specify any preferred or required timeline for implementing the style change.]

Possible Implementation Approach (optional):

[If you have any suggestions or ideas on how the style change could be implemented, feel free to provide them here.]

@github-actions
Copy link

Hello @Ishita-Ghosh-25!
Thank you for opening this new issue . We appreciate your interest in our project
we kindly request that you please review our Contributing Guidelines
https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md and Code of Conduct
https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md
thoroughly.
Mentors will review your issue. Meanwhile
please take a moment to check if a similar issue has already been opened.

@Siddhant-Patil0203
Copy link
Collaborator

Hey @Ishita-Ghosh-25
The issue here is the logo used on the first page is different, and the logo used on the home page is different,
therefore you just use the same logo used on the first page on the home page as well.

Also, can you change the font color of 'welcome' on home to white current its black?
here you Screenshot of it for your reference:
image

How it should be ✅

image

So can you do these two changes?

  1. Using the same logo used on the first page to the home page
  2. Change the font color of text 'Welcome' on home page

@Naresh-chandanbatve
Copy link
Collaborator

@Ishita-Ghosh-25

@Ishita-Ghosh-25
Copy link
Contributor Author

@Siddhant-Patil0203 sure. Will do

@Siddhant-Patil0203
Copy link
Collaborator

@Siddhant-Patil0203 sure. Will do

@Ishita-Ghosh-25 I am assigning you this issue.

@Ishita-Ghosh-25
Copy link
Contributor Author

@Naresh-chandanbatve here is the issue for which I have raised a PR

@Siddhant-Patil0203
Copy link
Collaborator

@Naresh-chandanbatve here is the issue for which I have raised a PR

Hey @Ishita-Ghosh-25 , you should refer to your issue no. on the PR you made not on the issue itself.
this is a good method, which helps maintainers to review your code properly.😄

keep a note of it, and happy coding 👨‍💻

@Siddhant-Patil0203 Siddhant-Patil0203 linked a pull request Jun 12, 2023 that will close this issue
13 tasks
Siddhant-Patil0203 added a commit to Ishita-Ghosh-25/StichHub that referenced this issue Jun 12, 2023
Siddhant-Patil0203 added a commit that referenced this issue Jun 12, 2023
"135 Logo And Home page UI Changed"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants