Updated DBC for v0.3.0 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanjoshi23
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the current brightside DBC to what the BOM contains. Frame1, although unusued, was still implemented. Things to look out for:
Some messages do not have parsing details such as float or int. This include "Throttle ADC reading", 0x402's "Bus Current", "Reset Command (currently unused)", 0x503's signals, 0x50B's signals, and 0x751. I understand some of these are guessable, however, clarity would be appreciated so that our ground truth stays as a good reference for debugging (we had a case of using int for the MotorVelocity and MotorCurrent signals which resulted in unnecessary debugging).
0x504 to 0x50A and 0x50C to 0x50E inclusive say see datasheet to determine the signals. More clarity here would be appreciated.
I also noticed a lot of movement of pre-exisitng messages such as 0x450's signals previously did not have an associated message (the signals simply existed as ID=3221225472 and "VECTOR__INDEPENDENT_SIG_MSG"). This is a good change.
The name Percentage of max current with ID = 0x401 seems like an odd change because it specifically refers to only 1 of the 2 signals. The previous name of MotorDriveCommand: I believe made more sense.
See Monday Update for more details.