Merging PRs into Robocup 2023 #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: itsarune <42703774+itsarune@users.noreply.github.com>
…g2002/Software into james/er_force_realism_toggle
…es/er_force_realism_toggle
Co-authored-by: itsarune <42703774+itsarune@users.noreply.github.com>
…g2002/Software into james/er_force_realism_toggle
…l_placement_play_test
…dy/Software into merging_codys_prs_and_tbotspy
…into merging_codys_prs_and_tbotspy
…oftware into merging_codys_prs_and_tbotspy
…anna/Thunderbots-Software into merging_codys_prs_and_tbotspy # Conflicts: # src/software/field_tests/field_test_fixture.py # src/software/thunderscope/thunderscope_main.py
nimazareian
changed the title
|
cab0c84 Add this to fix CI |
…areian/Software into merging_codys_prs_and_tbotspy
LiCody
previously approved these changes
Jul 4, 2023
itsarune
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Merging
#2946
#2940 (Turned off all pop up messages which freeze UI)
#2945
#2912
#2953
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue