Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul dev container #61

Merged
merged 31 commits into from
Jan 14, 2023
Merged

Overhaul dev container #61

merged 31 commits into from
Jan 14, 2023

Conversation

patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 commented Nov 23, 2022

Description

  • Resolves Explore alternative ways to install OMPL #33
  • Breaks ability to run Raye codebase
    • I don’t foresee a need to be able to run Raye and new project code together; the architectures of the 2 projects are different
    • Would probably be a pain to figure out ROS 1 bridge
    • Would simplify devcontainer and drastically reduce its size and build time, potentially leading to performance gains

Changelog

  • Base image
    • Ubuntu 18.04 -> 22.04
    • ROS eloquent -> humble
    • OMPL 1.5.0 based off script -> master branch based off dockerfile
    • Builds in 1 hr -> 10 min
      • Still uses a lot of RAM though, 16GB+ strongly recommended
  • Dev image
    • Network systems dependencies
      • clang: 10 -> 14 (default for 22.04)
      • googletest: 1.12 -> 1.11 (apt repository)
      • boost: 1.80 -> 1.74 (apt repository)
  • Dev container image
    • Size: 6.41GB -> 3.77GB

What's left

  • Update dev container to use the new dev image
  • Setup tools deprecation warning when building Python packages: add to Hacks and Known Issues #66
  • See if ROS autocomplete is working in zsh: will tackle in another issue Prompt Improvements #65
  • Add ARM versions of containers: will tackle in another issue Support ARM computers #31
  • Compare with the develop branch
  • Compare with the humble branch of athackst/vscode_ros2_workspace
  • Source ROS overlay in ~/.bashrc
  • Merge in Update Scripts to Migrate CI to Subteam Repos #60
  • Remove ament prefix from clang-tidy CI
  • Uncomment network_systems, comment out example repos
  • Merge with main
  • Run regression test
  • Create new branch named raye for what's in main before this gets merged in
    • Protect branch
    • Add it to workflows

After merging

@patrick-5546 patrick-5546 self-assigned this Nov 23, 2022
@patrick-5546 patrick-5546 added enhancement New feature or request sim Boat Simulator team labels Nov 23, 2022
@ubcsailbotsoftware ubcsailbotsoftware changed the title Develop v2 Overhaul dev container Dec 14, 2022
Make sure to change the network_systems branch to v2-updates in
src/new_projects.repos
@patrick-5546 patrick-5546 removed the request for review from hhenry01 January 14, 2023 02:10
@patrick-5546 patrick-5546 marked this pull request as ready for review January 14, 2023 02:10
@patrick-5546 patrick-5546 enabled auto-merge (squash) January 14, 2023 02:10
@patrick-5546 patrick-5546 merged commit 4860380 into main Jan 14, 2023
@patrick-5546 patrick-5546 deleted the develop-v2 branch January 14, 2023 02:12
@patrick-5546 patrick-5546 linked an issue Jan 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure sim Boat Simulator team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update sailbot_workspace Explore alternative ways to install OMPL
2 participants