Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-processing #62

Merged
merged 39 commits into from
May 12, 2021
Merged

Pre-processing #62

merged 39 commits into from
May 12, 2021

Conversation

fedderw
Copy link
Member

@fedderw fedderw commented Apr 14, 2021

Having numpy issues, the pre-processed csvs are not yet in there.

"Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed."

fixes #30, fixes #34, fixes #35

@pep8speaks
Copy link

pep8speaks commented Apr 14, 2021

Hello @fedderw! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 53:80: E501 line too long (84 > 79 characters)
Line 122:80: E501 line too long (85 > 79 characters)
Line 199:80: E501 line too long (95 > 79 characters)
Line 203:80: E501 line too long (80 > 79 characters)
Line 480:80: E501 line too long (90 > 79 characters)
Line 500:80: E501 line too long (84 > 79 characters)
Line 538:80: E501 line too long (85 > 79 characters)
Line 625:80: E501 line too long (86 > 79 characters)
Line 627:80: E501 line too long (97 > 79 characters)
Line 631:16: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 639:80: E501 line too long (88 > 79 characters)
Line 642:80: E501 line too long (80 > 79 characters)
Line 670:80: E501 line too long (80 > 79 characters)
Line 689:80: E501 line too long (84 > 79 characters)
Line 701:80: E501 line too long (86 > 79 characters)
Line 708:80: E501 line too long (87 > 79 characters)
Line 731:80: E501 line too long (88 > 79 characters)
Line 752:80: E501 line too long (83 > 79 characters)
Line 754:80: E501 line too long (83 > 79 characters)
Line 758:80: E501 line too long (83 > 79 characters)
Line 760:80: E501 line too long (83 > 79 characters)
Line 769:80: E501 line too long (80 > 79 characters)
Line 787:80: E501 line too long (83 > 79 characters)
Line 875:80: E501 line too long (81 > 79 characters)
Line 879:80: E501 line too long (81 > 79 characters)
Line 887:80: E501 line too long (81 > 79 characters)
Line 891:80: E501 line too long (81 > 79 characters)
Line 895:80: E501 line too long (87 > 79 characters)

Line 27:80: E501 line too long (81 > 79 characters)
Line 111:80: E501 line too long (87 > 79 characters)
Line 142:80: E501 line too long (82 > 79 characters)
Line 182:80: E501 line too long (84 > 79 characters)
Line 206:80: E501 line too long (86 > 79 characters)

Comment last updated at 2021-05-12 18:50:27 UTC

pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
@MaxGhenis
Copy link
Contributor

Also please format the code with black

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and minor suggestions. Could you check the TODO comments and either remove them if unnecessary, or move them into issues?

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
"New child poverty rate: "
+ child_poverty_rate_string
+ "%",
"New child poverty rate: " + child_poverty_rate_string + "%",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be in this pr but these string pieces could be simplified with a function

pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
Co-authored-by: Max Ghenis <mghenis@gmail.com>
fedderw and others added 8 commits May 7, 2021 15:00
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last minor things

pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
pre-processing.py Outdated Show resolved Hide resolved
@MaxGhenis MaxGhenis merged commit bfbd2b6 into UBICenter:main May 12, 2021
@MaxGhenis MaxGhenis linked an issue May 12, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants