Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap position x z coordinate interpretation #144

Closed
dave-doty opened this issue Oct 27, 2020 · 0 comments
Closed

swap position x z coordinate interpretation #144

dave-doty opened this issue Oct 27, 2020 · 0 comments
Assignees
@UnHumbleBen
Labels
high priority Something cruicial to get working soon.

Comments

@dave-doty
Copy link
Member

dave-doty commented Oct 27, 2020 •
edited by UnHumbleBen
Loading

Undo what was done to close issue #78 .

What I didn't realize when that was implemented is that it switched us from a right-handed coordinate system to a left-handed coordinate system. We want to go back to right-handed to make it simpler to export to 3D tools such as oxDNA.

Let's ensure backward compatibility here by bumping the minor version number once this is fixed, checking the version on import from a .sc file, and swapping the x-z coordinates on prior versions.

Related to web interface issue 488.
@dave-doty dave-doty added the high priority Something cruicial to get working soon. label Oct 27, 2020
@dave-doty dave-doty mentioned this issue Oct 27, 2020
Closed
UnHumbleBen added a commit that referenced this issue Nov 8, 2020
@UnHumbleBen
Rewrite none-grid example scripts for #144
34d24fe 
Swapped x and z values of helix groups and helix positions,
with the exception of 1_staple_1_helix_origami_position_nondefault.sc
where the exact position didn't matter
UnHumbleBen added a commit that referenced this issue Nov 9, 2020
@UnHumbleBen
Update proposal example for #144
a2a31f6
UnHumbleBen added a commit that referenced this issue Nov 9, 2020
@UnHumbleBen
Merge pull request #145 from UC-Davis-molecular-computing/dev-issue-144
beb3549 
Fixes #144; swap position x z coordinate interpretation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnHumbleBen UnHumbleBen

Labels
high priority Something cruicial to get working soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dave-doty @UnHumbleBen