Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with inter-helix-group crossovers when relaxing helix rolls #273

Closed
dave-doty opened this issue Aug 23, 2023 · 1 comment
Closed

deal with inter-helix-group crossovers when relaxing helix rolls #273

dave-doty opened this issue Aug 23, 2023 · 1 comment
Labels
closed in dev high priority Something cruicial to get working soon. invalid This doesn't seem right

Comments

@dave-doty
Copy link
Member

Currently, when relaxing helix rolls, all inter-helix crossovers are accounted for, but actually the calculation of the relative angle from one helix to another (based on the position of their 0 offset) only makes sense if the helices are in the same helix group, i.e., are parallel. If they are in different helix groups, we should do one of two things (possibly configurable with an option):

  1. (easy) ignore those crossovers
  2. (hard) do a more detailed calculation of the angle of the other helix, based not only on the helix's origin position, but also on the offsets of the two points on the helices the crossover connects.
@dave-doty dave-doty added invalid This doesn't seem right high priority Something cruicial to get working soon. labels Aug 23, 2023
dave-doty added a commit that referenced this issue Aug 23, 2023
…th-inter-helix-group-crossovers-when-relaxing-helix-rolls

fixes #273: deal with inter-group crossovers when relaxing helix rolls
@dave-doty
Copy link
Member Author

This was implemented via option 1. We can explore option 2 in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed in dev high priority Something cruicial to get working soon. invalid This doesn't seem right
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant