Oxview export #246
Merged
Oxview export #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgevans
commented
Sep 11, 2022
| @@ -7807,6 +7881,11 @@ def __str__(self) -> str: | |||
| def __repr__(self) -> str: | |||
| return '_OxdnaVector({}, {}, {})'.format(self.x, self.y, self.z) | |||
|
|
|||
| def __iter__(self) -> Iterator[float]: | |||
There was a problem hiding this comment.
This is generally convenient, so that list(vector) gives a list [x,y,z]. I don't use it in the code, but do in the tests.
cgevans
commented
Sep 11, 2022
| @@ -12,6 +13,7 @@ | |||
| import scadnano.origami_rectangle as rect | |||
| import scadnano.modifications as mod | |||
|
|
|||
| from scadnano.scadnano import _convert_design_to_oxdna_system | |||
There was a problem hiding this comment.
This seems like a cleaner way of testing equality to the oxDNA design. The oxDNA tests already test that export format.
dave-doty
requested changes
Sep 11, 2022
|
Is this ready to merge? |
It should be: it works, and the tests cover a variety of odd cases. I'll eventually want to do something similar for oxDNA exports, but there are other considerations for that (forces file format, another file to export, etc), and for now, oxview is useful enough (and can export forces files anyway). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oxview's format is largely similar to a json version of oxDNA files, though we can also set the color of each nucleotide.
This code is currently messy, and needs tests and documentation. It currently exports correctly with my large tile systems, but I haven't tested it more thoroughly.
Closes #173.