270 ignore same helix crossovers when calculating helix rolls #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also ensures domains on helix are stored in increasing order of start offsets
dave-doty
deleted the
270-ignore-same-helix-crossovers-when-calculating-helix-rolls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore "same helix" crossovers when calculating helix rolls. Also ensures that domains stored on a helix (stored in field
Helix._domains, calculated when callingDesign._build_domains_on_helix_lists) stores domains in sorted order of start offset (breaking ties with forward/reverse).Related Issue
#270