Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo "inline insertions/deletions" should undo setting of helix tick marks #761

Closed
dave-doty opened this issue Apr 5, 2022 · 2 comments · Fixed by #767
Closed

undo "inline insertions/deletions" should undo setting of helix tick marks #761

dave-doty opened this issue Apr 5, 2022 · 2 comments · Fixed by #767
Assignees
Labels
bug Something isn't working

Comments

@dave-doty
Copy link
Member

Create this design:

image

Select "Edit→Inline insertions and deletions". It results in this as expected:

image

Now press Ctrl+Z to undo. It should go back to the first picture where the tick marks are 0, 4, 8, but instead it retains the tick marks as 0, 5, 9:

image

@dave-doty dave-doty added the bug Something isn't working label Apr 5, 2022
@dave-doty
Copy link
Member Author

This also happens with paired insertions:

image

then inline:

image

Then select Undo:

image

But it's purely a View problem; the design appears to be properly undone. If you refresh the page, you see the original design.

@dave-doty dave-doty changed the title undo "inline insertions/deletions" does not undo setting of helix tick marks undo "inline insertions/deletions" should undo setting of helix tick marks Apr 12, 2022
@dave-doty
Copy link
Member Author

This was a subtle issue to find. The cause was the memoized getter Helix.calculate_major_ticks returning a List<int> instead of BuiltList<int>; see issue #766.

dave-doty added a commit that referenced this issue Apr 12, 2022
…line-insertionsdeletions-does-not-undo-setting-of-helix-tick-marks

fixes #761: undo "inline insertions/deletions" should undo setting of helix tick marks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants