-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlapping domains should not be able to be drawn #855
Comments
Oh wow... is that by clicking in the small white space in the helix adjacent to the existing domain? At any rate, this is definitely a bug and should just be prevented. Thanks for finding it! |
illegal design
error when making domains overlap…ping-domains-should-not-be-able-to-be-drawn fixes #855: overlapping domains should not be able to be drawn
I don't know how to reproduce this. If it can be reproduced, re-open the issue and describe in detail what steps are needed to create the design shown in the first comment above. |
Ah, I see it now! scadnano prevents dragging the cursor into the middle of the domain, but if you reach to the other side of it, it allows you to draw it. Hmm, right now I'm not seeing how to fix the logic in a way that won't re-introduce the bug in #883, but maybe we can discuss in our next meeting |
I removed the "closed in dev" because this behavior still appears on the dev server (https://scadnano.org/dev/) and when I run locally from the dev branch. I'm a bit confused about the history here, I see some of the comments here were made after PR #860, but for some reason I thought we had fixed this issue again after that. |
Looks like domains can be created like this:
When this happens, no error is immediately thrown, but when reloading the page, this message appears:
Click to show
The text was updated successfully, but these errors were encountered: