Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display DNA sequence on extension in order 5' to 3' #959

Closed
damienwoods opened this issue Dec 22, 2023 · 1 comment
Closed

display DNA sequence on extension in order 5' to 3' #959

damienwoods opened this issue Dec 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/

Comments

@damienwoods
Copy link
Collaborator

damienwoods commented Dec 22, 2023

DNA sequence 5'-TTT ATA ... ATC-3' was assigned to an extension (in scadnano-python by concatenating scadnano.Extension(num_bases=len(seq), dna_sequence=seq, display_angle=40, display_length=6) to a list of strand domains) is being displayed in the wrong (i.e. reverse) order on the bottom of a design. Extensions on the top of a design look fine.

image

When DNA sequences are exported from the design, this particular DNA sequence is in the correct order.

@damienwoods damienwoods added the bug Something isn't working label Dec 22, 2023
@dave-doty
Copy link
Member

dave-doty commented Dec 22, 2023

Just to illustrate the problem, here are other contexts in which the sequence is backward. In each case, the strand has sequence 5'-AAATA-CCCCCCCC-AAATA-3'. The backwards extensions are circled in green below:

image

So the general problem is that the DNA sequence is always drawn with 5' on left and 3' on right, and the mistake above correspond to cases where the extension reverses that: its 3' end is on the left and its 5' end is on the right.

Note that the two strands on the bottom helix are essentially the same as those on the top helix, only the free ends of their extensions have been dragged inward, so that their display_angle is greater than 90 degrees.

@dave-doty dave-doty changed the title DNA sequence in wrong order on extension display DNA sequence on extension in order 5' to 3' Dec 22, 2023
@dave-doty dave-doty self-assigned this Dec 22, 2023
dave-doty added a commit that referenced this issue Dec 22, 2023
…-dna-sequence-on-extension-in-order-5-to-3

fixes #959: display DNA sequence on extension in order 5' to 3'
@dave-doty dave-doty added the closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/ label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants