Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #488; swap position x z coordinate #499

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Fixes #488; swap position x z coordinate #499

merged 5 commits into from
Nov 9, 2020

Conversation

UnHumbleBen
Copy link
Collaborator

Changes

  • Documentation updated
  • UI logic for coordinate change
  • Import logic for backward compatibility
  • Helix groups import and UI logic handled as well
  • Unit testing updated for new change
  • Unit testing for importing older designs
    • includes older designs that uses helix groups

Other Fixes:

Fixes #497
Fixes #498

TODO (before merging)

Generate examples in both python and this repository

* Documentation updated
* UI logic for coordinate change
* Import logic for backward compatibility
* Helix groups import and UI logic handled as well
* Unit testing updated for new change
* Unit testing for importing older designs
  - includes older designs that uses helix groups
Copy link
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty busy, so I'll assume this has been tested carefully.

Note that I pushed a bit to the dev branch recently; hopefully merging is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants