-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
895 export base pair lines #955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why, but it's not working for me when copying a PNG image. I create this design:
Then select and copy image:
But when I paste into Powerpoint, no base pair lines:
It does work if I Export an SVG file:
Open the SVG file in Inkscape:
I suspect it would help to refactor the code exporting selected strands to SVG and to PNG to share more code, so that if one gets fixed so does the other.
It should work now. It was a quick fix. In |
The new commit renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why I didn't approve this last month. I'll approve it for now since it seems to look okay, hopefully there's not something I missed that needs to be done still.
Added export SVG support for base pair lines.
Changes
_base_pairs(bool allow_mismatches)
to_base_pairs(bool allow_mismatches, BuiltSet<Strand> selected_strands)
. Now base_pairs isthis._base_pairs(false, strands.toBuiltSet())
andselected_base_pairs(BuiltSet<Strand> selected_strands)
just calls_base_pairs
directly.base_pair-{helix-id}-{offset}
so we can identify the base pairs that is inselected_base_pairs
.List<Element> get_selected_base_pairs(Store<AppState> store)
that mirrors the behavior ofList<Element> get_selected_strands(Store<AppState> store)
so that it adds the base pair HTML elements into the exported SVG.