Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#897 option to display rectangle #966

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

rayzhuca
Copy link
Member

@rayzhuca rayzhuca commented Mar 4, 2024

Description

Created a new display option for base pairs: rectangle.
Moved changed the display into a dialog box.

Screenshots (if appropriate):

The dialogue box.
Screenshot 2024-03-03 at 6 43 32 PM
The display when display with rectangle and even if mismatched as false.
Screenshot 2024-03-03 at 6 20 44 PM

@rayzhuca rayzhuca requested a review from dave-doty as a code owner March 4, 2024 02:46
@rayzhuca rayzhuca linked an issue Mar 4, 2024 that may be closed by this pull request
@rayzhuca rayzhuca changed the title #897 option to displagy rectangle #897 option to display rectangle Mar 4, 2024
Copy link
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer a slightly different way of specifying view options.

Instead of popping up a dialog, can we make it all configurable from the submenu View-->Base pairs, similar to View-->Modifications? There, if "Show modifications" is unchecked, that's all you see:

image

but then if you check it, you see the additional options:

image

That's what I had in mind for these options, if unchecked, it looks like it did before, and if checked, then you see something like this directly in the submenu:

image

I don't know if the React Bootstrap library we are using for submenus allows radio buttons, but if not we can just have "lines" and "rectangle" be two checkboxes, and set up the React render code so that exactly one of them is checked (according to the value AppState.AppUIState.base_pair_display_type)

@rayzhuca
Copy link
Member Author

rayzhuca commented Mar 5, 2024

I couldn't find the radio buttons so I just made it into checkboxes like you suggested.

@rayzhuca rayzhuca merged commit 6dc78a6 into dev Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to display paired bases with gray rectangle
2 participants