Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis results improvements #282

Merged
merged 34 commits into from Nov 20, 2020
Merged

Analysis results improvements #282

merged 34 commits into from Nov 20, 2020

Conversation

orbitfold
Copy link
Collaborator

No description provided.

jlakhlili and others added 30 commits November 18, 2020 12:14
@jlakhlili
Add get_sobol_second to PCEAnalysis Results
a4cd69d
@jlakhlili
Update PCE tuto.
3f5f305
@jlakhlili
Merge branch 'dev' into sob-2nd
5907f6c
@orbitfold
changes to sobols_total
e100812
@orbitfold
re-implemented sobols_first and sobols_total
408f8c6
@orbitfold
typo fix
e96b7db
@orbitfold
updated doctstrings
7cf3a65
@orbitfold
added some argument checks to first and total sobol index methods in …
55870b0 
…results
@orbitfold
fix some typos
6ce4cd4
@orbitfold
changes to the test
91d38cf
@orbitfold
some updates
96c946c
@orbitfold
changes to the test
ebbab52
@orbitfold
added a test to check vector qoi resutls
b2d4eba
@orbitfold
updated docstring examples
808c38b
@orbitfold
Merge pull request #281 from UCL-CCS/sob-2nd
2bc508c 
PCEAnalysis Results: Add a getter for Sobols 2nd
@orbitfold
changes to sobols_total
dfcc656
@orbitfold
re-implemented sobols_first and sobols_total
9d010d4
@orbitfold
typo fix
40777f0
@orbitfold
updated doctstrings
95473c4
@orbitfold
added some argument checks to first and total sobol index methods in …
fbc162c 
…results
@orbitfold
fix some typos
c2e90ba
@orbitfold
changes to the test
6c2e6c6
@orbitfold
some updates
9ce4945
@orbitfold
changes to the test
6078328
@orbitfold
added a test to check vector qoi resutls
f9cfffd
@orbitfold
updated docstring examples
f7b3c35
@orbitfold
Merge branch 'analysis-results-improvements' of https://github.com/UC…
0e1b436 
…L-CCS/EasyVVUQ into analysis-results-improvements
@orbitfold
updated results analysis in pce
5292870
@orbitfold
work on second order sobol index reporting
3792e8b
@orbitfold
updated sobols reporting
f0e5abb
@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2020

This pull request introduces 1 alert when merging 15b2238 into 2bc508c - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@dww100
Copy link
Collaborator

dww100 commented Nov 19, 2020

The LGTM analysis seems to be highlighting a double return statement in _get_sobols_second (from pce_analysis.py). It would be best to ensure the right one is being used before merging.

@orbitfold
Copy link
Collaborator Author

The LGTM analysis seems to be highlighting a double return statement in _get_sobols_second (from pce_analysis.py). It would be best to ensure the right one is being used before merging.

Oh yeah sorry, it was working I just forgot to remove the second return.

@orbitfold orbitfold merged commit 66fe418 into dev Nov 20, 2020
@orbitfold orbitfold deleted the analysis-results-improvements branch December 3, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dww100 dww100 dww100 approved these changes

@jlakhlili jlakhlili jlakhlili approved these changes

@raar1 raar1 Awaiting requested review from raar1

@wedeling wedeling Awaiting requested review from wedeling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orbitfold @dww100 @jlakhlili