Environment parameters #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygego
reviewed
Nov 29, 2019
anthonygego
added a commit
that referenced
this pull request
Dec 21, 2019
GuillaumeDerval
added a commit
that referenced
this pull request
Jan 8, 2020
This reverts commit ddda939.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mechanism to have different "environment parameters" for different "environment types".
An agent announces multiple environment, each having an environment type, which can be different.
The frontend then displays in the studio parameters specific for this particular environment type.
Most of the time I expect that one agent = one environment type, but that is not mandatory.
The original problem was that MCQ tasks do not need a time limit, and that we had in the past wanted to add specific parameters for the MCQ to modify the behavior of the agent.
This PR modifies the task.yaml format. All the docker-related parameters are now environment parameters. All environment parameters are stored inside a key
environment_parameters.This implies that we have to modify every task.yaml for all the existing tasks. We have the choice of either doing in on-the-fly in INGIninous (currently done in the PR: https://github.com/UCL-INGI/INGInious/compare/env_parameters?expand=1#diff-7225411b5e409292ee4524fe95f36102R163)
or to do a script to update everything.