Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible==10.0.0 breaks the workflows #115

Open
paddyroddy opened this issue Jun 5, 2024 · 3 comments
Open

ansible==10.0.0 breaks the workflows #115

paddyroddy opened this issue Jun 5, 2024 · 3 comments
Labels
problem Something isn't working

Comments

@paddyroddy
Copy link
Member

Short Description

Not entirely sure what the breakage is, but probably related to #110. This has been fixed for now with #114 - but ideally we don't want to pin ansible long-term.

Evidence/Steps to Reproduce

Run molecule with ansible>=10.0.0

Acceptance Criteria/Expected Behaviour

No response

Details

No response

Resolution

No response

@HChughtai
Copy link
Member

Rather than pinning a specific version, shall we specify that we use a major version and install that - e.g. pip install "ansible==9.x" so that the latest version in that line is used? Then we can have a more considered upgrade to ansible==10.x when we're ready?

@HChughtai
Copy link
Member

Ansible 9 will have minor and bugfix releases until Novemeber 2024

And worth looking at the Ansible 10 roadmap to see if any of the breaking changes are relevant to us.

@paddyroddy
Copy link
Member Author

Having discussed this with @HChughtai, think I'm going to change it to ansible_major_version and use the 9.* syntax in the composite action

paddyroddy added a commit that referenced this issue Jun 5, 2024
In the process of fixing things around #115, we want to use different
options in the composite action related to
UCL-MIRSG/.github#121 &
UCL-MIRSG/.github#122. This would mean we'd need
to set extra options in the reusable workflow, which will get confusing.
By removing the reusable workflow, this will simplify things greatly.
This will lead to more verbose code, but better in the long-term.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants