Add option to specify molecule command
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
commented
Jun 5, 2024
| python3 -m pip install --upgrade pip | ||
| python3 -m pip install \ | ||
| molecule molecule-plugins[docker] docker requests | ||
| run: >- |
There was a problem hiding this comment.
I find >- generally leads to more readable code
drmatthews
approved these changes
Jun 5, 2024
paddyroddy
added a commit
to UCL-MIRSG/ansible-collection-infra
that referenced
this pull request
Jun 5, 2024
In the process of fixing things around #115, we want to use different options in the composite action related to UCL-MIRSG/.github#121 & UCL-MIRSG/.github#122. This would mean we'd need to set extra options in the reusable workflow, which will get confusing. By removing the reusable workflow, this will simplify things greatly. This will lead to more verbose code, but better in the long-term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action was fairly hardcoded towards running
molecule test, so have changed the descriptions a bit.