-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scanner number of axial components is not logical for BlocksOnCylindrical #1374
Comments
I have been looking at STIR/src/buildblock/GeometryBlocksOnCylindrical.cxx Lines 102 to 104 in ee307c7
Should the second loop terminate at num_axial_blocks_per_bucket = 2 , not num_axial_blocks=6 . num_axial_buckets = 3 and is derived by
using the num_rings STIR/src/include/stir/Scanner.inl Lines 161 to 167 in ee307c7
|
I agree, it looks like the second loop should be be looping over the blocks per bucket. I wonder why I never ran into any issues with this - will look at it when I have a moment. Nonetheless, I agree it would be very nice to have some errors if the scanner definition contains conflicting parameters. |
I believe that most of the tests use a single axial bucket and that doesn't encounter any issue. |
I will create a PR with the aforementioned test and an attempted fix today. |
Yep, that's it - I never use more than one bucket axially. Thanks! |
The conversion has been moved to #1374 |
Throw errors if incorrect/unsupported blocks scanner. See #1374
@KrisThielemans : can this be closed? |
I think so. @robbietuk please confirm (and close) |
Closing as #1385 resolved the issue. |
Issue
I have have been experiencing an issue related to the number of axial crystals in a scanner when the wrong
num_rings
value is input. I had the rough configurationThe issue I found is that everything is created cleanly but when back projecting a uniform 1s to a generated volume, the back projection only occurred in 1/3 of the volume. Note, this is only an issue with
BlocksOnCylindrical
.CTest Example
Created a test to demonstrate the issue:
Output
Note there is no warning or errors that indicate an issue with the block geometry. I think part of the issue is there is no validation to match the
num_rings
to the number of axial crystals. Could this be because of the complications of virtual crystals in other scanners?The text was updated successfully, but these errors were encountered: