Small improvements #1366
Merged
Small improvements #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we require C++-14, so remove work-around for compilers without partial template specialisation or mutable
"new style" forward/back projector was r6unning checks on _density_ptr, even though it was created/tested before. callgrind shows that has_same_charecteristics is actually surprisingly expensive (as it calls Array::get_index_range(), which is slow). So now we avoid doing those checks. This results in a (quite small) speed-up, only relevant for GPU projectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove workarounds from
Arrayand small speed-up for projectors.These commits are/were on #1236, but that's not yet ready to merge.