Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for origin shift #260

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactoring for origin shift #260

wants to merge 7 commits into from

Commits on Dec 19, 2019

  1. Places that changes need to occur to account for bed position

    @ashgillman
    Richard Brown authored and ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    d47f975 View commit details
    Browse the repository at this point in the history

  2. [REF] Use m_in_mm instead of t_in_mm in ProjMatrixByBinUsingRayTracing

    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    140eb32 View commit details
    Browse the repository at this point in the history

  3. [REF] Simplify calculation and correction of phi and s_in_mm In ProjM… 

    …atrixByBinUsingRayTracing
    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    dd0d2df View commit details
    Browse the repository at this point in the history

  4. [REF] Remove unneeded argument to ray_trace_one_lor()

    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    fada50f View commit details
    Browse the repository at this point in the history

  5. [REF] Use DiscretisedDensity's index <-> physical space conversions i… 

    …n ProjMatrixByBinUsingRayTracing
    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    8322933 View commit details
    Browse the repository at this point in the history

  6. [REF] Address comments https://github.com/UCL/STIR/pull/260/files/036… 

    …5f964a565fa488b278e6a5eb20fa337572b11
    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    ad686ac View commit details
    Browse the repository at this point in the history

  7. FIX: Do better with test_DataSymmetries... 

    Now passes until non-standard range of planes.
    @ashgillman
    ashgillman committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    120419c View commit details
    Browse the repository at this point in the history