-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a versioning system. #203
Conversation
It's a bit fiddly, but @willGraham01 : you can check out your local copy of Then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good, but I believe you should handle the case where there is no git repository, which if I understand correctly (but haven't tried) may result in some errors when running CMake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit fiddly, but @willGraham01 : you can check out your local copy of
main
and merge this feature branch in (or cherry-pick the commit) to test.Then
git tag v100.99.98
(or whatever) and compile as normal, then checktdms --version
.
Seems all good: cmake
happily picks up if I'm sat at a tag
, and failing that provides the auto-generated version string you specified. -DTDMS_version
overrides both as predicted, although I made a comment about how adamant it is about doing this between builds.
If the user grabs a snapshot tarball then there is no git repo so fall emit a friendly warning message and fall back to the default release name defined in globals.h.
If the user grabs a snapshot tarball then there is no git repo so emit a friendly warning message and fall back to the default release name defined in globals.h.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=====================================
- Coverage 48% 24% -24%
=====================================
Files 63 62 -1
Lines 7808 3593 -4215
=====================================
- Hits 3760 874 -2886
+ Misses 4048 2719 -1329
☔ View full report in Codecov by Sentry. |
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
<branchname>_<tag or short format commit hash>
.For example this commit has the "version"
201-versioning-in-cmake_b16cd31
.With a bit of luck I've explained all of this in the developers documentation 😸
Resolves #201.
Cheers @giordano and @alessandrofelder for suggestions. @giordano : if you have time and any opinions, they'd be appreciated.