Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spdlog version to v1.11.0. #228

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Update spdlog version to v1.11.0. #228

merged 1 commit into from
Feb 7, 2023

Conversation

samcunliffe
Copy link
Member

v1.10 → v1.11

@samcunliffe samcunliffe added technical Technical and meta issues, not related to physics but infrastructure. housekeeping Code cleanup labels Feb 6, 2023
@samcunliffe samcunliffe marked this pull request as ready for review February 6, 2023 20:46
@samcunliffe samcunliffe added the review required A review approval is required before merging label Feb 6, 2023
willGraham01
willGraham01 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@willGraham01 willGraham01 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a pretty large diff, but I think I got the gist of what was going on 😅

Merging this in now.

@willGraham01 willGraham01 merged commit 67abd8c into main Feb 7, 2023
@willGraham01 willGraham01 deleted the update-spdlog-version branch February 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willGraham01 willGraham01 willGraham01 approved these changes

Assignees
No one assigned
Labels
housekeeping Code cleanup review required A review approval is required before merging technical Technical and meta issues, not related to physics but infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samcunliffe @willGraham01