DRY our .github/workflow #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
force-pushed
the
141-dry-workflow
branch
from
6a0f8d6
to
0f6b923
Compare
samcunliffe
force-pushed
the
141-dry-workflow
branch
from
924708f
to
faae591
Compare
samcunliffe
force-pushed
the
141-dry-workflow
branch
from
86cb0aa
to
a86304b
Compare
samcunliffe
added
testing
samcunliffe
force-pushed
the
141-dry-workflow
branch
from
78f7cd0
to
afd42ee
Compare
willGraham01
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Mostly a few small comments for my own GitHub actions understanding. Also we might be able to close #41 now?
samcunliffe
commented
Mar 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... it was a bit WET. (Where T=thrice)
Changes
I've merged all three OS builds (plus the linter job) into one workflow. And I've made the steps dependent:
linter → builds → system tests.
This means:
I think we want 2 because: 🌱 . I looked into making the system tests not wait for all builds (i.e. start as soon as the build artifact appears), but I couldn't figure out how to do it short of merging the system tests and builds job back together. And I anyway don't really want to do that because of 2.
Name
Since it's back to one workflow we only have three badges now. I've called it "build and test" but open to renaming it if you can think of anything better.
Sorry for the noise!
I realise now that I almost certainly should have tested this on my own private fork with no watchers. Potentially you got a lot of rebasing, force push and commit emails. Hopefully, everyone unsubscribed. My bad.