Track generation for arc_02 and arc_03
#241
Conversation
willGraham01
force-pushed
the
wgraham-input_data_arc0203
branch
from
576b3b4
to
496fe04
Compare
There was a problem hiding this comment.
Messy review that I had started already and then just ... didn't click "Submit"?
Let me send the comments now, even though they may become obsolete after #236 is tweaked.
| @@ -17,4 +17,5 @@ tests: | |||
| input_generation: | |||
| input_file: input_file_01.m | |||
| spatial_obstacles: ["fs", "cyl"] | |||
| illumination_input_file: | |||
| illsetup: | |||
There was a problem hiding this comment.
Sorry for the pedestrian question: is illsetup used in TDMS proper?
... Because I preferred illumination_input_file for its explicitness. Perhaps illumination_setup (whole words).
willGraham01
force-pushed
the
wgraham-input_data_generation
branch
from
7967bbd
to
5aa7cd2
Compare
- Updates run_bscan.m to handle illsetup and non-cyl obstacles - Updates config files to use illsetup rather than illumination_file key for brevity - illsetup is a bool flag, not a string now - scattering_matrix handles the setup of spatial objects via a string option - generate_test_input can handle regenerating data according to illsetup or no illsetup, and different spatial objects
…stacle sizes across tests.
- doc/developers directs readers to config_01.yaml for explanation of the config files - Docstrings are added to run_bscan - Default values are placed into a dictionary in generate_test_input.py to avoid duplication and account for changes later.
Rename illfile_required to illsetup in run_bscan wrapper. - There are distinct usage cases (sometimes an illfile has to be created, other times it is provided as a .mat input.) - As such, the name must be explicit in this case.
willGraham01
force-pushed
the
wgraham-input_data_arc0203
branch
from
d235cd0
to
d8f70ba
Compare
|
Rebased this guy now too. In response to the previous comments:
The However, you can also just provide |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage ? 47.56%
=======================================
Files ? 63
Lines ? 7804
Branches ? 0
=======================================
Hits ? 3712
Misses ? 4092
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@codecov probably did the comparison with |
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
Continues #240 |
Adds
arc_02andarc_03to the list of tests which are now covered by the input data regeneration scripts.Modifications on top of #236:
run_bscannow handles different spatial objects, obstacle radii, and whenillsetupis required on top of the usualfilesetup.config_XX.yamlandinput_file_XX.mare added to thedata/input_generationfolder appropriatelygenerate_input_data.pyhas been split intobscan_arguments.pyandgeneration_data.pycontaining classes of the same name, to separate functionality.Reduces the number of variables and input parameters that were stored more than once across the test classes(this is redundant because the classes now no longer exist in the base branch)test_regen.pywill run tests in numerical order when called locally, which is nice.Force-push changes here 👉 #241 (comment)