Add arc_09 and arc_10 to the scope of test_regen.py
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
force-pushed
the
wgraham-input_data_arc08_12_13
branch
from
bdddd87
to
4cc8bc5
Compare
- Adds the point-source option to scattering_matrix - Changes the argument order to scattering_matrix to better reflect input dependency - Adjusts the order arguments are passed in run_bscan to match - Updates the README with point-source option
- run_bscan now needs to be told whether to calculate a time-domain field for the illumination - bscan_arguments accordingly now needs to store an additional variable from the config file - example syntax in config_01 updated accordingly - add required methods calc_field_tdfield and getsourcecoords to the matlab/ directory
- .m files can now save auxillary .mat files with only the selection of variables requested - "calc_tdfield" field is correctly searched for when reading config files - run_bscan now returns the names of the files it created - generate_test_input now cleans up all but the reference files and generated input files when it finishes - generate_test_input actually passes the calc_tdfield flag to run_bscan - bscan_arguments.py rebase artefact removed
willGraham01
force-pushed
the
wgraham-input_data_arc_09_10
branch
from
030c4fb
to
90ca4ea
Compare
samcunliffe
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues towards #236 |
Tests added
arc_09andarc_10can now be run usingtest_regen.py, and have their input data remade locally.run_bscanchanges:run_bscanhandles the case when the user provides a.mattime-domain field as the illumination source (through thecalc_tdfieldflag)run_bscannow returns the filenames of the input.matfiles it regenerated, so we can remove all other unnecessary.matfiles that the input generation process creates.Additional changes
arc_09)config_01.yaml's example to reflect the newcalc_tdfieldoptional flaggetsourcecoordsandcalc_field_tdfieldadded to repository as necessary functions for the input generation to run