Add more tests for the argument parsing. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy to add some simple tests of argparsing functionality.
samcunliffe
commented
Apr 26, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 47.56% 48.09% +0.52%
==========================================
Files 63 63
Lines 7804 7804
==========================================
+ Hits 3712 3753 +41
+ Misses 4092 4051 -41 ☔ View full report in Codecov by Sentry. |
samcunliffe
force-pushed
the
test-arg-parser
branch
from
4679ff1
to
c36ba7d
Compare
willGraham01
approved these changes
Apr 27, 2023
| [](const std::string &s) { return s.c_str(); }); | ||
| return arr; | ||
| } | ||
| // TODO: check with Will that this doesn't shadow the implementation |
There was a problem hiding this comment.
I am still not super in-the-lingo; but if you're worried that the executable is meant to do this conversion itself, it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An easy train ride and TI planning background task: add some simple tests of arg-parsing functionality.
Not a high priority to review. (Although should be relatively quick.)
Also, and this is not normally good practice, fix a totally unrelated typo