Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example script path #273

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix example script path #273

merged 2 commits into from
Apr 27, 2023

Conversation

willGraham01
Copy link
Collaborator

Context/Description

More details

Updates the additional path added to the MATLABPATH when running the example script, so that MATLAB can find the required files.

Testing

examples/arc_01 can now be run using the instructions in the README.md and does not error.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@669121b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage        ?   47.56%           
=======================================
  Files           ?       63           
  Lines           ?     7804           
  Branches        ?        0           
=======================================
  Hits            ?     3712           
  Misses          ?     4092           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍉

Comment on lines +59 to +63

%%
figure;
imagesc(dat_cyl.z_i, dat_cyl.x_i, abs(squeeze(dat_cyl.Hz_out)));
axis equal;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a second image, does it?
+1 to leaving it in though, if it's the nice sphere one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes our sphere logo in fact! Want me to add some flavour text and an actual title?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is flavour text?
I mean sure: go nuts.

@samcunliffe samcunliffe merged commit d8baa55 into main Apr 27, 2023
12 checks passed
@willGraham01 willGraham01 deleted the wgraham_fix_example branch April 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix example script
2 participants