Update catch2 #275
Merged
Update catch2 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.3 has some nice features. Including a SKIP() macro. 💙
samcunliffe
added
testing
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 47.56% 47.66% +0.10%
==========================================
Files 63 63
Lines 7804 7724 -80
==========================================
- Hits 3712 3682 -30
+ Misses 4092 4042 -50 ☔ View full report in Codecov by Sentry. |
willGraham01
approved these changes
Apr 27, 2023
samcunliffe
added a commit
that referenced
this pull request
May 15, 2023
* Update catch2. v3.3 has some nice features. Including a SKIP() macro. 💙 * Skip the segfault test.
samcunliffe
added a commit
that referenced
this pull request
May 16, 2023
* Update catch2 (#275) * Update catch2. v3.3 has some nice features. Including a SKIP() macro. 💙 * Skip the segfault test. * SKIP unit tests if sample data not generated. Since we're introducing a bit of complexity into the unit-testing framework, at least we should skip the tests (developer quality of life) with a nice warning explaining why. * Skip function. 2 lines → 1. And gets rid of another global. Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com> * Revert to explicitly skipping the broken test. --------- Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com>
willGraham01
added a commit
that referenced
this pull request
May 19, 2023
* Update catch2 (#275) * Update catch2. v3.3 has some nice features. Including a SKIP() macro. 💙 * Skip the segfault test. * SKIP unit tests if sample data not generated. Since we're introducing a bit of complexity into the unit-testing framework, at least we should skip the tests (developer quality of life) with a nice warning explaining why. * Skip function. 2 lines → 1. And gets rid of another global. Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com> * Revert to explicitly skipping the broken test. --------- Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com>
willGraham01
added a commit
that referenced
this pull request
May 19, 2023
* Update catch2 (#275) * Update catch2. v3.3 has some nice features. Including a SKIP() macro. 💙 * Skip the segfault test. * SKIP unit tests if sample data not generated. Since we're introducing a bit of complexity into the unit-testing framework, at least we should skip the tests (developer quality of life) with a nice warning explaining why. * Skip function. 2 lines → 1. And gets rid of another global. Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com> * Revert to explicitly skipping the broken test. --------- Co-authored-by: willGraham01 <willGraham01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3 has some nice features. Including a
SKIP()macro. 💙