A kindof trivial test addition to help debug #279. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't hurt to test our utils but I'm mostly interested in the change in coverage for the utils.cpp file.
samcunliffe
commented
May 4, 2023
| REQUIRE_NOTHROW(assert_can_open_file(path.c_str(), "a+")); | ||
|
|
||
| REQUIRE_THROWS_AS(assert_can_open_file(path.c_str(), "NONEXISTANT_FILE_MODE"), | ||
| std::runtime_error); |
There was a problem hiding this comment.
One could argue that this is pointless: I'm using an std::stringstream to test a function that basically wraps fopen. 🙃
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 48.09% 48.18% +0.09%
==========================================
Files 63 63
Lines 7804 7803 -1
==========================================
+ Hits 3753 3760 +7
+ Misses 4051 4043 -8
☔ View full report in Codecov by Sentry. |
From the
From the ... didn't learn as much as I had hoped. |
|
Almost not worth your time, but @willGraham01 this may as well go in if you can spare 30 secs to review. |
willGraham01
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't hurt to test our utils but I'm mostly interested in the change in coverage for the utils.cpp file.