Openandorder refactor #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-young31
force-pushed
the
openandorder_refactor
branch
from
06ecb8e
to
9f2f033
Compare
t-young31
commented
Jul 22, 2022
giordano
reviewed
Jul 22, 2022
At the moment I'd say there are more important things to do than unit testing the argument parsing that has some system tests, but could be persuaded otherwise! |
giordano
approved these changes
Jul 25, 2022
Merged
prmunro
approved these changes
Jul 27, 2022
t-young31
force-pushed
the
openandorder_refactor
branch
from
6186828
to
e86d7b9
Compare
Rename Add argument parser class Extract function Delete non required standard specification Include stdecept Remove unused header file Refactor saveoutput Refactor openandorder Extract class [skip actions] Extract matrix collections Include stdexcept More stdexcept More function extraction include cstring Extract functions Extract class Include stdexcept Self review changes tmp t
t-young31
force-pushed
the
openandorder_refactor
branch
from
e86d7b9
to
3bd56d0
Compare
willGraham01
approved these changes
Aug 1, 2022
dstansby
reviewed
Aug 2, 2022
There was a problem hiding this comment.
I haven't looked at detail into ftdd_grid_initialiser.cpp, matrix_collection.cpp, or openandorder.cpp as they seem copy/pasted and changing the code is outside scope of this PR. Otherwise looks 👍 with some minor suggestions
As a general comment, would be good to get a linter to enforce consisted code style asap. I'm happy to open an issue for that?
|
Oh, also a rebase onto main to get a CI run in would be good |
Co-authored-by: David Stansby <dstansby@gmail.com>
dstansby
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
openandorder. This PR adds: