Settings page

[saachipahwa]

the navigation bar at the bottom isn't showing so i hope i didn't break it (all i meant to do was add a new page).
(i renamed the old settings to testing and made a new settings page)

[thevirtuoso1973]

You don't need to leave in old stuff that works in case you've broken it, it clutters up the PR.

[thevirtuoso1973]

It seems broken on my device.

• I can't read icons, it's white.
• Two 'debug' labels is suspicious.
• I don't see a 'change' button. Make sure it resizes properly.
• Show me a keypad if you're going to enforce only digits for support code.
• The screen goes blank when I try to type in something.

[thevirtuoso1973]

Regardless of the above, the priority is to finish IntroScreen for now.

[saachipahwa]

here is what it looks like now, it's the same as what I did in making-it-pretty branch but with the changes you requested

[thevirtuoso1973]

Cool re-request review when ready.

[thevirtuoso1973]

Nav bar labels show up in white, so I can't read it. Also, all the pages should have the same bg color so you update the others as well.

[saachipahwa]

Nav bar labels show up in white, so I can't read it. Also, all the pages should have the same bg color so you update the others as well.

That's being done in 'making pages pretty' branch

[thevirtuoso1973]

I can't see the pic you've uploaded, I think you pressed comment before waiting for it to upload?

[saachipahwa]

validation works

[thevirtuoso1973]

@saachipahwa Yep as I said you don't need the onChange/current postcode thing so I pushed a commit. The main reason it works is cos I call save() inside setState, so it redraws that widgets and therefore calls the future again as well.

[thevirtuoso1973]

Also, haven't looked at all the pages yet.

[thevirtuoso1973]

In addition:

• I can't read icon labels (they are in white).
• Font size seems too big. (The text in wellbeing page gets cut off on my device, e.g. "- Normalized Ste|")

[saachipahwa]

Should there be a back button on the checkup page, that takes them back to the app? or the bottom navigation bar

[thevirtuoso1973]

Should there be a back button on the checkup page, that takes them back to the app? or the bottom navigation bar

I don't think so, it should close when they submit, and we sort of expect them to perform the checkup.

[thevirtuoso1973]

LGTM but review and merge #49 first.

[thevirtuoso1973]

Can you resolve conflicts?

[thevirtuoso1973]

Also some updated screen shots at the top of the page would be good.

[saachipahwa]

Updated screenshots