use the category type for performance wins #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is complaining because diff has been removed. Our test show that this works but does not make a huge difference. |
|
Good to know about the category data type. I can definitely see this being useful. Does this particular change still make sense even though there's not much performance difference? |
|
Sorry, just got back from a trip. I don't think it matters much, but I think it makes sense the point of the function is to make categories that may as well be "Categorical." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So just came across Categorical Data in pandas, and this blog post on how it dramatically improves performance on data with text categories.
This is not yet tested, but I think it makes sense. What do you think? Are there other places that need it?