Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoryerror pd sum sum #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Memoryerror pd sum sum #46

wants to merge 2 commits into from

Conversation

cvanoli
Copy link
Collaborator

@cvanoli cvanoli commented May 3, 2018

-Deleted pd.sum.sum which was giving memory error. Changed it to a for loop summing on every row

@coveralls
Copy link

coveralls commented May 3, 2018

Coverage Status

Coverage increased (+0.07%) to 82.873% when pulling d390e2f on memoryerror_pd_sum_sum into c3588e4 on master.

@janowicz
Copy link
Contributor

janowicz commented May 8, 2018

@cvanoli Thanks. Per our existing discussions with @sablanchard, this low-memory change should be made an optional one (e.g. a high-level low_memory parameter that defaults to False), so that those with the requisite memory can avoid the for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants