Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis script #68

Merged
merged 6 commits into from Nov 16, 2020
Merged

Update Travis script #68

merged 6 commits into from Nov 16, 2020

Conversation

smmaurer
Copy link
Member

@smmaurer smmaurer commented Nov 11, 2020

This PR updates the Travis script, to simplify it and run tests in newer Python environments. Also updates some other ancillary things that came up in the process.

Travis script

Old version: .travis.yml
New version: .travis.yml

This runs the same code style and unit tests, removing some outdated cruft -- replaces a Conda custom environment with pip install ., drops an old slack notification system, etc. Tests now run in Python 2.7, 3.5, 3.6, 3.7, and 3.8.

Python 3.6+ will use current versions of Pandas and NumPy, but earlier environments will use older versions, which is helpful for maintaining backward compatibility.

Pandana syntax

Running the tests in newer environments raised a few errors related to Pandas deprecations, which I fixed:

  • pd.Series.nonzero() -> pd.Series.values.nonzero()
  • pd.Series.as_matrix() -> pd.Series.values()
  • pd.Index.name = -> pd.Index.set_names()

Other changes

  • added a requirements-dev.txt file to list the additional packages used for testing in a central place
  • switched the code style checks from pep8 to pycodestyle

@smmaurer smmaurer requested a review from PyMap November 11, 2020 19:00
@msoltadeo
Copy link
Contributor

Looks ok to me

@coveralls
Copy link

coveralls commented Nov 11, 2020

Coverage Status

Coverage remained the same at 82.451% when pulling 35e8b79 on update-travis into f8dbfc4 on develop.

@PyMap
Copy link
Collaborator

PyMap commented Nov 16, 2020

@smmaurer pandas updates are fine to me! I will approve for those ones and let you decide regarding the travis checks! Thanks for accomodating this!

@smmaurer smmaurer merged commit b7de06e into develop Nov 16, 2020
@smmaurer smmaurer deleted the update-travis branch November 16, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants