Fix bpmodloader conversion error #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened when a directory name contained a unicode character. According to my tests with this fix applied, unicode characters translate properly between wstring and our own to_string function and iterating the results of "IterateGameDirectories" and using Luas "print" function will properly display the unicode characters in the console. Added two notes to the changelog, one documenting the underlying problem that was fixed, and another one documenting the upstream feature that was fixed because of that. This is so that people that experience this problem can recognize it as fixed in the changelog.
|
Note to maintainers (particularly @Buckminsterfullerene02): The checklist in the pull request template doesn't mention whether all checks are required and some of the checks don't suggest that you should check them if they aren't applicable. |
|
Hmm yeah I think the PR template is a bit OTT, I should trim it down to be something less "filtered" i.e. removing checklists and making sure people have made a commit updating changelog/docs if required |
Buckminsterfullerene02
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See commit message: 79b328f
Fixes #396 and #365
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
See commit message: 79b328f
Checklist
Screenshots (if appropriate)
Additional context
Add any other context about the pull request here.