fix(C++ Mods): Delayed mod constructor until imgui is initialized #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UE4SS
force-pushed
the
imgui-mod-context-fix
branch
from
bd159c7
to
4226328
Compare
|
I've realized this fix isn't sufficient. |
|
The proper fix will probably involve introducing |
UE4SS
force-pushed
the
imgui-mod-context-fix
branch
from
4226328
to
b79b0a7
Compare
This only happens if the mod uses 'UE4SS_ENABLE_IMGUI' macro in the constructor, which is no longer supported, you should use the new 'on_ui_init' instead. The purpose of this is to guarantee that imgui context has been set before a mod uses any imgui functions. Previously, we were assuming that the context would be set by the time the mod construct was called, however this was actually a race condition. It was possible for the mod constructor to be called before the UI code in UE4SS created the imgui context.
UE4SS
force-pushed
the
imgui-mod-context-fix
branch
from
b79b0a7
to
319736d
Compare
|
This is now ready. |
narknon
approved these changes
Apr 22, 2024
trumank
added a commit
to trumank/kismet-debugger
that referenced
this pull request
Apr 26, 2024
narknon
added a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: Truman Kilen <t@kilen.me> #481
narknon
added a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: Truman Kilen <t@kilen.me> #481
narknon
added a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: Truman Kilen <t@kilen.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This only happens if the mod uses
UE4SS_ENABLE_IMGU' macro in the constructor.The purpose of this is to guarantee that imgui context has been set before a mod uses any imgui functions. Previously, we were assuming that the context would be set by the time the mod construct was called, however this was actually a race condition. It was possible for the mod constructor to be called before the UI code in UE4SS created the imgui context.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
See #469
Checklist
Please delete options that are not relevant. Update the list as the PR progresses.