Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player background from series #244

Open
UEWBot opened this issue Nov 21, 2022 · 3 comments
Open

Add player background from series #244

UEWBot opened this issue Nov 21, 2022 · 3 comments
Labels
enhancement player background Issues relating to the background of players

Comments

@UEWBot
Copy link
Owner

UEWBot commented Nov 21, 2022

Now that we can identify series of tournaments, it would be nice to have series-specific background for players. For example "X won this tournament 3 years ago" or "Y has finished as high as 3rd at this tournament".

@UEWBot UEWBot added enhancement player background Issues relating to the background of players labels Nov 21, 2022
@UEWBot
Copy link
Owner Author

UEWBot commented Nov 21, 2022

This would be an addition to Player._tourney_rankings(), with a new MASK value or values to include background from the series.

@UEWBot
Copy link
Owner Author

UEWBot commented Nov 23, 2022

Possible background items:

  • Best finish in series
  • Number of times player has won a series event (note that this will be an "at least" number because most series pre-date the SW)
  • Previous wins in the series
  • Defending champion
  • Previous best result in the series as a specific power
  • Previous best country awards in the series as a specific power

UEWBot added a commit that referenced this issue Jan 25, 2023
In Tournament.background(), also report if any of the players previously
won any tournament in the same series.

Issue #244
@UEWBot
Copy link
Owner Author

UEWBot commented Jan 27, 2023

This isn't quite as straight-forward as I'd hoped, because Player._tourney_rankings() looks at PlayerTournamentRankings but to do this we need to go through Series. The first patch does that independent of _tourney_rankings(). Probably need to break that out into a separate method somewhere and expand it to add the other background items noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement player background Issues relating to the background of players
Projects
None yet
Development

No branches or pull requests

1 participant