Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Custom Fan Card for Air Purifiers #107

Open
13robin37 opened this issue Dec 19, 2021 · 5 comments · May be fixed by #134
Open

Adjust Custom Fan Card for Air Purifiers #107

13robin37 opened this issue Dec 19, 2021 · 5 comments · May be fixed by #134
Assignees

Comments

@13robin37
Copy link
Contributor

Currently the custom_card_saxel_fan by @saxel works only for traditional fans (which is fine), however Air Purifiers like the Xiaomi ones work with the fan integration for the most part as well.

In my opinion the current button which triggers call-service fan.osciallate should switch between fan modes Off and Auto for purifiers. Should I set up a new custom card or integrate something within the existing card?

@CM000n
Copy link
Collaborator

CM000n commented Dec 19, 2021

Thank you so much for figuring this out! In my opinion, we should avoid redundant cards that look the same and do the same thing, just a little differently.
So I would rather prefer the second solution by feeling. But let's wait for the feedback from @saxel. Maybe he has another opinion about it.

@saxel
Copy link
Contributor

saxel commented Dec 21, 2021

Hello, sorry for the delayed response (just got back from a short vacation, also dealing with aftermath from flooding reaching into my apartment). I also have the same brand of air purifier but I haven't found a use case for controlling fan speed and off/auto. Mine is strictly controlled via automations.

I suppose if you want to control the air purifier fan speed with a slider then I agree with @CM000n that the 2nd suggestion makes sense, if it is okay that the slider is visible even when the air purifier fan speed is set to Auto.

@13robin37 do you want to give it a try with implementing? Otherwise I can have a look either later today or within a couple of days depending on my time available.

@CM000n CM000n linked a pull request Dec 22, 2021 that will close this issue
4 tasks
@13robin37
Copy link
Contributor Author

@saxel I will try to implement something in the next few days when I have some free time.

@13robin37
Copy link
Contributor Author

Apologies for the delay on this one, we've moved and I'm slowly picking up speed on Home Assistant projects again! 🙃

@lucasfr
Copy link

lucasfr commented Jul 25, 2022

I'm not sure whether I am missing something but it would also be good to hide the oscillate button. Could not find anything in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants